Bug 133: (zippyzee) Hi,- buy 3 items (so you shou...

[BugTracker]

Bug ID       : 133 - Hi,- buy 3 items (so you shou... 
Bug Date     : 2015/01/24 03:18:40
Assigned To  : zippyzee
Priority     : Low

Category     : VGClient
Sub-Category : Gameplay: Inventory
Severity     : Severe (e.g. Exploitable)
Reproducible : Every time

Details:
Hi,
- buy 3 items (so you should have the items on slot 1,2 and 3 into your inventoryà)
- open bank inventory
- move the third item to the first bank slot -> your item into the first slot of your inventory also moves -> Nok
- move the item from the first bank slot into the second bank slot -> same thing append to the second inventory slot.

Originated From World: New Telon (1)
Chunk                : Khal (85)
Location             : -7256 -52048 1545

[zippyzee]

Very good! I had seen something similar during testing but didn't recreate it this way. The bug centers around checking to swap item locations when moving these items around. The bank and your bag have the same bag_id, and the slots are numbered similarly. If you move an item from inventory to the bank, it was trying to swap the phantom item from the same slot in the bank (which was really in your inventory bag) and find a new home for everything. I added a check to make sure the old and new item locations were the same when comparing if the slot is already occupied. Fix is in rev. 988.

Keep it up. This is the kind of thing we need to find. If I had in-game items or coins to give out, I would!

[Blackstorm]

Np Zippyzee ^^
Thanks for your fix ^^ i will try it asap

Edit : tryied on rev988 and not reproducible ^^ Thanks a lot ^^