Bug 94: (zippyzee) When picking an inventory item...

[BugTracker]

Bug ID       : 94 - When picking an inventory item... 
Bug Date     : 2015/01/13 05:09:17
Assigned To  : zippyzee
Priority     : Low

Category     : VGClient
Sub-Category : Other
Severity     : Standard
Reproducible : Every time

Details:
When picking an inventory item and putting anywhere into the bag, it will flash on top left corner before going to your selected spot in the bag. I am simply picking up the item with left click and left clicking to drop it again

Dont know if thats inventory items only. Also still cant rightclick items off inventory

Originated From World: New Telon (1)
Chunk                : Nusibe Necropolis (51)
Location             : 11041 52418 10137

[zippyzee]

This is prior to recent versions, so right-clicking should always work now.

The other issue is very interesting. I can't see it on my client, but I know why it is doing it. The routine is currently unquiping an item first, and then placing it in the correct location. The unequip code moves the item to the first open slot, which would be the top left corner. It is then processed to move into the desired slot. All of that should be happening instantaneously, but if there is some lag you might be able to see it.

The real solution is to remove putting an item into an inventory slot from the unquip routine, or add a flag for certain items as having a real destination. I had to do the reverse for equipping items via moving to a specific location vs. right-clicking. In one case you know exactly where you are wanting to put something, in the other you want to find an open slot, and if there is none, swap out the default slot. For the sake of programming elegance, it's great if one function can handle both scenarios cleanly, and people writing code down the line don't have to figure out what they need to do--just send the item's id and desired slot (or right-clicked) and let it do its job for you.

I posted this to remind myself to fix it. Otherwise it's just a visual glitch of the underlying process and not an actual bug.

[zippyzee]

I think this will be fixed in the next server update (rev 957 or greater), although since I can't see it, I can't verify it. If it happens again please report.

[Moldew]

Right-clicking an equipped item will always put it back in slot 1 or next available slot, regardless of what slot you had it in when equipped from bags.

Rev 957.

[zippyzee]

If you had, say, a 1H weapon in inventory and right-clicked it to equip, it would move the 1H weapon that was already equipped into that inventory slot, and you could go back and forth if you kept right-clicking. Essentially a swap. That is my recollection anyway. If not, it makes a lot more sense to be that way and that's how I have it set up. And it does feel natural. On the other hand, if you are right-clicking to unequip an item, it will just go to the first available bag slot.

However, I always hated that. I had specific spots in specific bags that I kept my alternate earrings, etc., and when unequipping something I would have preferred it go back to the bag and slot (if available) where it came from. Vanguard does keep the bag and slot information on the equipped items. When you equip an item, the equip slot changes from -1 to whatever equipment slot it goes to, but the bag and slot do not change. So it would be possible (and I plan on doing this, unless everyone objects) to go back to the bag and slot it originally came from (if available), and if the slot is occupied go to the first available slot in any bag.

In this particular case, this occurs when dragging an equipped item to an inventory bag slot. It would first unequip the item as though it had been right-clicked, and then move it to the spot. That's what the player was seeing. Now it just goes directly to the spot.