Bug 79: (zippyzee) - buy 3 new bags (i.e :

[BugTracker]

Bug ID       : 79 - - buy 3 new bags (i.e :  
Bug Date     : 2015/01/11 05:17:46
Assigned To  : zippyzee
Priority     : High

Category     : VGClient
Sub-Category : Gameplay: Inventory
Severity     : Severe (e.g. Exploitable)
Reproducible : Every time

Details:
- buy 3 new bags (i.e : "Pristine Jute Bag")
- equip the first one on the first additionnal bag slot : ok
- equip the 2nd one on the second addtionnal bag slot : NOk
- same for the 3rd

Originated From World: New Telon (1)
Chunk                : Khal (85)
Location             : -8146 -57784 1595

[Glaxono]

I can confirm this bug I hate to call it a bug though as I know you are still actively working on these various actions.

Results of testing:
Only 1 bag can be equipped and only in the 1st open bag slot .
Unable to equip bags in the 2nd and 3rd bag slots
Right-clicking on a bag in inventory just replaces the already equipped bag in the 1st slot
The 1 saddlebag slot is not affected and works properly

[Glaxono]

Another issue related to bags:

An equipped bag with 1 or more items can be moved to inventory by right-clicking another UN-equipped bag (which should not happen)
The bag with items is now in inventory but cant be moved around into other inventory slots because of error "Who may not place an occupied container in you main inventory"
You can re-equip the occupied but UN-equipped bag by either dragging it to a bag slot or right-clicking it

This issue also exists with the saddlebag

[zippyzee]

Duly noted. I hope to be able to start looking at these kind of things again this week.

[Xinux]

Here is some more information on this.

The client is sending the correct slot it wants the bag to go in to but the server is sending a different slot almost as if bag's aren't being added to the inventory list?

Client wanting to put the bag in the 3rd slot (27) going left to right starting with the saddlebag.

Code: Select all

-- OP_Unknown_143 --
1/12/2015 16:08:55
10.15.155.65 -> 10.15.155.64
0000:	00 09 0D 41 02 00 8F 00 00 00 08 00 00 00 41 00 ...A..........A.
0010:	00 00 1B 00 00 00                               ......

Server moved my existing bag from slot 12 to my inventory at slot 48

Code: Select all

-- OP_ServerInvItemAdd --
1/12/2015 16:28:45
10.15.155.64 -> 10.15.155.65
0000:	00 09 0A 1A 02 00 A9 01 00 00 0C 00 00 00 41 00 ..............A.
0010	00 00 30 00 00 00 FF FF FF FF                   ..0.......

Now it's equipping the bag that was for slot 27 to slot 12.

Code: Select all

-- OP_ServerEquipItem --
1/12/2015 16:28:45
10.15.155.64 -> 10.15.155.65
0000:	00 09 0A 1B 02 00 A7 01 00 00 06 00 00 00 44 00 ..............D.
0010	00 00 00 0C                                     ....

[zippyzee]

I will be able to look at it tomorrow. I have known for some time that this was not fully implemented yet, but all of this will be helpful and hopefully won't be too much trouble to overcome. If I can get the bags to cooperate, and start masking equipment slots then we are going to be close to getting this done.

[zippyzee]

Most of this is fixed and working properly. I have a few more things to do to make it more robust, and then will commit.

[zippyzee]

Committed fix for this issue; once it goes live (rev. 945) please let me know of further problems.

[John Adams]

This is live on New Telon as of now (dev rev 945)

[Glaxono]

The fix for bags worked but also introduced a few more bugs and/or unforeseen reflexes

Equipping bags to OPEN slots by either dragging or right-clicking now works properly. However,

Issue 1)
- When dragging a bag to an occupied slot, the dragged bag is placed on top of the existing bag (Two bags in one slot) and another unrelated bag is moved to inventory!
- Also, If you have a forth bag in inventory and all bag slots full, right-clicking the bag in inventory places it on top of the equipped bag in slot 1 (closest to your default bag) and another unrelated bag is moved to inventory!

Issue 2
- An equipped bag with 1 or more items can be moved to inventory by right-clicking another UN-equipped bag (which should not happen) if all bag slots are full
The bag with items is now in inventory but cant be moved around into other inventory slots because of error "You may not place an occupied container in your main inventory"
- You can re-equip the occupied but UN-equipped bag by either dragging it to a bag slot or right-clicking it
- This issue also exists with the saddlebag

I hope I didn't over-complicate the steps to reproduce