Zoning/Chunking

[theFoof]

[quote="Xen"][quote="theFoof"]So, any idea why this problem doesn't occur as frequently on linux? I would think it would happen exactly the same way.[/quote][/quote]

Well the problem is originating from sockets and those work differently on linux/windows so I'm assuming that's why.

[John Adams]

If it wasn't said before, I think this bug also affects players in the same chunk. I saw a player online, so I launched my client to test multi-connections. I got into my zone fine and ran around a bit, but then got booted back to Select. Once there, I could not get back into my world. the other player appears to still be moving around the world.

I closed my client and relaunched it and now at Select, it is "Waitin gon data from New Telon" so the TCP connection is whacked.

[theFoof]

Just committed some tweaks to various places in net code that should make chunking/the server a bit more stable. I doubt this is 100% resolved though.

[theFoof]

I don't know if this is being sent often on zoning and I just haven't noticed it before but, found an unhandled SOE protocol code 0x0019, that could also cause issues.

[theFoof]

Okay so I hooked up valgrind, and when zoning is freezing now I'm getting invalid read/writes on multi packets. I added a logger on to check if size == 255 and sure enough after a bunch of zoning I got a packet like that. So size is overloaded or something on multi packets, doing further research on it now.

EDIT: Not positive that size is overloaded but some multi packets are not reading correctly when this is happening. Not sure exactly what's wrong with our reading or the packets yet.

[Xinux]

That is the -- OP_ReadyToZoneMsg -- packet looking at it not sure it was read wrong.

Here are two examples of it.

Code: Select all

0000:	02 00 09 00 00 00 8C 00 00 00 EB FF FF FF 0D 00 ................
0010:	00 00 00 00 00 00 B8 FA 5B 25 04 00 00 00 00 00 ........[%......
0020:	00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
0030:	00 00 00 00 00 00 41 29 40 10 68 28 05 0F 00 70 ......A)@.h(...p
0040:	EB 04 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
0050:	00 00 00 00 00 00 00 00 00 00 F0 00 4C 0B ED FF ............L...
0060:	FF FF FF FF FF FF 13 00 00 00 00 00 00 00 00 00 ................
0070:	00 00 92 D9 4F 10 EB FF 0D 00 B8 CE 30 08 01 00 ....O.......0...
0080:	00 00 0D 00 00 00 EB FF FF FF 6C F2 18 00 C0 F2 ..........l.....
0090:	18 00 20 CC FE 00                               .. ...

Code: Select all

0000:	00 09 00 2A 02 00 09 00 00 00 8C 00 00 00 EB FF ...*............
0010:	FF FF 0C 00 00 00 00 00 00 00 B8 FA 5B 25 04 00 ............[%..
0020:	00 00 49 29 40 10 68 28 05 0F 68 28 05 0F 00 00 ..I)@.h(..h(....
0030:	00 00 04 70 EB 04 00 00 00 00 41 29 40 10 68 28 ...p......A)@.h(
0040:	05 0F 00 70 EB 04 04 70 EB 04 00 00 00 00 00 00 ...p...p........
0050:	7C 05 00 00 00 00 00 00 00 00 00 00 00 00 09 00 |...............
0060:	BE 02 ED FF FF FF FF FF FF FF 11 00 00 00 00 00 ................
0070:	00 00 33 68 CC 00 92 D9 4F 10 EB FF 0C 00 B8 CE ..3h....O.......
0080:	30 08 01 00 00 00 0C 00 00 00 EB FF FF FF 6C F2 0.............l.
0090:	18 00 C0 F2 18 00 20 CC FE 00                   ...... ...

[theFoof]

Here's an example of a 0x03 packet that's being read incorrectly.

[Xinux]

ok the packet looks fine.

You have a 03 with a size of 250 followed by a 19 which breaks down like this.

96 = 150
24 = 36
0a = 10
48 = 72

The 03 ends right before the 48 09

Code: Select all

00000000: 00 03 CD 00 09 00 A8 00 19 96 02 00 00 00 00 00 ................
00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00000030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00000040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00000050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00000060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00000070: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00000080: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00000090: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
000000A0: 24 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 $...............
000000B0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
000000C0: 00 00 00 00 00 0A 09 00 00 00 00 00 00 00 00 00 ................
000000D0: 48 09 00 00 00 00 00 00 00 00 00 00 00 00 00 00 H...............
000000E0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
000000F0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00000100: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00000110: 00 00 00 00 00 00 00 00 00 79 70                .........yp