VGVisualParser - missing packets

[John Adams]

Scat, you helped me solve the bad "en dash" problem, but I think there's another one. I am not sure how. Maybe an ASCII save of a log that had an en dash?

I noticed in a Dialog packet, opcode 801 shows 2 packets in it, because of that damnable ?- issue.

From Parser:

Code: Select all

-- OP_Unknown_801 --
2/6/2014 20:39:22
69.174.203.9 -> 192.168.1.100
0000:	02 00 21 03 00 00 0C 00 00 00 6F 06 00 00 09 00 ..!.......o.....
0010	00 00 00 00 00 00                               ......


?- OP_Unknown_1409 --
2/6/2014 20:39:22
69.174.203.9 -> 192.168.1.100
0000	02 00 81 05 00 00 04 00 00 00 04 00 00 00       ..............

The actual packet in the log:

Code: Select all

–- OP_Unknown_801 --
2/6/2014 20:39:22
69.174.203.9 -> 192.168.1.100
0000:	02 00 21 03 00 00 0C 00 00 00 6F 06 00 00 09 00 ..!.......o.....
0010	00 00 00 00 00 00                               ......


–- OP_Unknown_1409 --
2/6/2014 20:39:22
69.174.203.9 -> 192.168.1.100
0000	02 00 81 05 00 00 04 00 00 00 04 00 00 00       ..............

From HexEditor:

Code: Select all

–- OP_Unknown_1409 --
0x13, 0x20, 0x2D, 0x00, 0x20, 0x00, 0x4F, 0x00, 0x50, 0x00, 0x5F, 0x00, 0x55, 0x00, 0x6E, 0x00, 
0x6B, 0x00, 0x6E, 0x00, 0x6F, 0x00, 0x77, 0x00, 0x6E, 0x00, 0x5F, 0x00, 0x31, 0x00, 0x34, 0x00, 
0x30, 0x00, 0x39, 0x00, 0x20, 0x00, 0x2D, 0x00, 0x2D, 0x00, 0x00, 0x00, 

clearly it's 0x13,0x20 again.

What else can I put in that if to catch this bad byte?

[Scatman]

Where in the source is it doing the first check? I can't remember what that if statement was and I'll be home a little later tonight.

[John Adams]

It's in the Log.cs, Parse() function, right after it finds a \n new line I believe. We're looking for -- to signify the beginning of a new packet. While I don't like that being such a requirement, it is what it is, and works mostly. So no need to change it unless it's simple (?)

I guess I could put a check that if buf[0] isn't a dash, and isn't a 150 (en dash), maybe break to see what it thinks it found? You might have a better idea.