Bug 348: (zippyzee) Spamming the complete quest button

[BugTracker]

Bug ID       : 348 - Spamming the complete quest button 
Bug Date     : 2015/12/09 02:09:23
Assigned To  : zippyzee
Priority     : High

Category     : VGClient
Sub-Category : Gameplay: Quest
Severity     : Severe (e.g. Exploitable)
Reproducible : Every time

Details:
Spamming the complete quest button can get multiple turn ins, complete with multiple XP rewards and item rewards.

Originated From World: New Telon (1)
Chunk                : Isle of Dawn (1)
Location             : -15045 19672 1415

[zippyzee]

Yes, there are no checks in place for this and other 'bad' player behavior yet, but I am aware of it. It is particularly a problem multi-looting the nuts on the flower quest.

[zippyzee]

I put in a fix for this but will need verification.

[Jakkal]

Is the fix on Targonor?

Edit: Just tried to run through the quests to get to the rewards, but uh, I think it crashed. I'm not sure if I lost connection or if the server d/c'd me but I can't get back on.

[Xinux]

Yup you crashed it taking a chance to update the server with the new code it will be back up in a minute.

[Jakkal]

Whoops, looks like I broke it again. Seems to happen when I take the quests from uh, Sixfish? I think that's his name, the one that gives you the seed quest and the gataro kill quest. Seems to happen either when I take those quests from him, OR when I get the seeds. I can successfully get the seeds, but the garatos no longer have the dots over their names, and when I try to kill them, that's when it starts up.

Not on my lunch break anymore so I can't break it again <:)

[zippyzee]

Not sure if the quests have been linked back up on New Targ, yet, as far as correct scripts and questgivers/turnins.

[Xinux]

It's not that it's this which is causing the crash.

Combat.cpp
if (lua_spell->is_ticking) {

[Moldew]

Status?

[Xinux]

This seem's fixed locally can someone test NT and update.