Bug 235: (zippyzee) NPC Stuttering Movement

[zippyzee]

In the npc motor ai, in CombatDo(), it sets the npc offensive target to the most hated character each cycle. That is triggering the notification change, which is in turn sending a packet that doesn't need to be sent.

There will be a check in there at the next commit that only sets the offensive target if it is not the current offensive target.

[zippyzee]

This should be better now. So every 200ms since npc's have been able to do combat it has spammed this packet for every npc in combat. Not only that, but the path there through the code involves locking a list, updating it, unlocking it, etc. Performance enhanced!

[John Adams]

Great job, sleuths. Xinux should re-run his combat test now and post the results for comparison. I love performance.

btw, NT updated to current SVN. Until I get home, we will have sprinting NPCs.

[Xinux]

Looks good.

Code: Select all

08:47:03.976 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:04.319 E Char     Notify Offensive Target Details changed e:\vgoemu\trunk\src\world\worldcharacter.cpp:655
08:47:04.319 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:06.990 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:08.520 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:10.004 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:12.565 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:16.031 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:16.594 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:19.045 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:20.825 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:22.059 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:24.839 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:25.073 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:28.087 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:28.899 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:31.101 E Char     Process Damage e:\vgoemu\trunk\src\world\combat.cpp:632
08:47:31.101 D Item     Adding item 1032867 (Surgin Hilthorn's Right Leg) with unique_id 0 to pawn inventory.
08:47:31.226 D NPC      Gataro Podling Exiting Combat
08:47:31.226 E Char     Notify Offensive Target Details changed e:\vgoemu\trunk\src\world\worldcharacter.cpp:655
08:47:31.226 E Char     Notify Offensive Target Details changed e:\vgoemu\trunk\src\world\worldcharacter.cpp:655