World Crash: CheckPlayerChangedContinents (Chat)

[John Adams]

Great, so the world is crashing alright, but not in the ThreadRun we need it to

Better stack:

Code: Select all

 	ntdll.dll!77cb8537()	Unknown
 	[Frames below may be incorrect and/or missing, no symbols loaded for ntdll.dll]	
>	WorldServer.exe!Mutex::ReadLock() Line 99	C++
 	WorldServer.exe!WorldCharacter::IsInChatChannel(unsigned int id) Line 218	C++
 	WorldServer.exe!WorldCharacter::SendChatChannels() Line 374	C++
 	WorldServer.exe!ChunkServer::CheckPlayerChangedContinents(std::shared_ptr<Client> & client, std::shared_ptr<WorldCharacter> & character) Line 1878	C++
 	WorldServer.exe!ChunkServer::HandleClientAuthConfirm(std::shared_ptr<Client> & client, PacketStruct * packet_struct) Line 1311	C++
 	WorldServer.exe!ChunkServer::ProcessPackets() Line 377	C++
 	WorldServer.exe!ChunkPacketThread(void * data) Line 121	C++
 	WorldServer.exe!ThreadRun(void * arg) Line 77	C++
 	WorldServer.exe!_callthreadstart() Line 255	C
 	WorldServer.exe!_threadstart(void * ptd) Line 239	C
 	kernel32.dll!7716337a()	Unknown
 	ntdll.dll!77c492e2()	Unknown
 	ntdll.dll!77c492b5()	Unknown

In Mutex.cpp @ while (!TryAcquireSRWLockShared(&lock))

But walking back up the stack, to auto wclient = net.GetClient(character->GetAccountID()); wclient is empty, from the destroyed HandleClientAuthConfirm function


The console is a sea of red:
[quote]23:15:36.053 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.054 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.055 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.056 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.057 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.058 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.060 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.061 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.062 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.063 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.064 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.065 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.067 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.068 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:15:36.069 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:15:36.070 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.071 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:15:36.072 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.073 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:15:36.075 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.076 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.077 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.078 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.079 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.080 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.082 E Attrib Value (0) is greater then attribute max (-1) for attribute 238 at c:\vgoemu\src\world\worldchara
cter_attributes.cpp:305
23:15:36.083 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:15:36.084 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.085 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.086 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.087 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.089 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.090 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:15:36.091 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:835
23:15:36.093 D Ability Loaded 0 forms for character id 435.
23:15:36.094 E Char AddTitle: The character Sile already has the title 'Citizen'.
23:15:36.095 E Char AddTitle: The character Sile already has the title 'of VGOEmulator'.
23:15:36.097 D Char Loading Inventory for character_id 435
23:15:36.147 I Char Loaded 121 items for character_id 435
23:15:36.148 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Loud Criticism'.
23:15:36.149 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Enticing Whisper'.
23:15:36.151 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Read My Lips'.
23:15:36.152 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Shifting Arguments'.
23:15:36.153 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Gut Feeling'.
23:15:36.154 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Greener Pastures'.
23:15:36.156 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Aggressive Statement'.
23:15:36.157 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Itemized Comparison'.
23:15:36.158 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Flat Dismissal'.
23:15:36.159 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Lay Blame'.
23:15:36.161 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Truth Be Told'.
23:15:36.162 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Disarming Rebuttal'.
23:15:36.163 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Snippet of Wisdom'.
23:15:36.164 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Frank Discussion'.
23:15:36.165 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Exchange of Views'.
23:15:36.167 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Common Ground'.
23:15:36.168 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Moral Authority'.
23:15:36.169 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Varanthari Stare'.
23:15:36.170 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Sorcerer's Point'.
23:15:36.171 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Piece of Mind'.
23:15:36.172 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Bit of Charm'.
23:15:36.174 E Diplo AddDiplomacy: The character Sile already has the diplomacy card 'Flash of Inspiration'.
23:15:36.176 D Char ToggleIsOnline: Setting player online
23:15:36.179 D Char Successfully loaded character 'Sile' (435)
[/quote]

Entire log attached

[Xinux]

Was thinking about this shouldn't we check at the start of ChunkServer::HandleClientAuthConfirm to make sure the client pointer is valid?

Something like this or the such?

Code: Select all

void ChunkServer::HandleClientAuthConfirm(shared_ptr<Client>& client, PacketStruct* packet_struct) {
	if (client == nullptr) {
		LogError(LOG_CHARACTER, 0, "HandleClientAuthConfirm: client == nullptr");
		udp.BeginDisconnectFromServer(client, CLIENT_DISCONNECT_CONNECT_FAIL);
		return;
	}
	const char* name = packet_struct->GetString("player_first_name");

[zippyzee]

Every time we access a function through a pointer we should check to make sure it is valid beforehand. Every. Time.

[shargash]

I'm not sure if this is related to the current topic, but I there was a crash of NT tonight (8/27, around 10:00PM EDT). I encountered several oddities before the server went away.

1. I tried several times to log in to the game, but I was stuck "waiting on New Telon." The client was not hung (i.e. the animations were proceeding, and the UI was responsive), I just couldn't get any characters to display. I tried several times with the same results, including relaunching the launchpad, etc.

2. Eventually I got a character and was able to log in to the game (Tursh Village). The launchpad said there were 0 users on NT, but I did a /who to see if anyone else was logged on. The command never came back (I tried several times). Client commands (e.g. /time) were working fine, and I was able to move around.

3. I tried .rift Khal. The client indicated the rift was starting (i.e. I was stuck staring at my shoes), but I never actually changed chunks.

4. I killed the client and launchpad and tried again. The server responded with a list of characters, and I selected a different character and clicked "start." The screen cleared, but the character never logged in.

5. I killed the client and launchpad again. This time the client actually froze while waiting on NT (i.e. the animations were frozen and the UI unresponsive). I launched taskpad and killed the client.

6. When I re-started launchpad again, NT showed as down and has been so since then.

[Xinux]

Code: Select all

>	WorldServer.exe!std::_Fetch_add_seq_cst_2(volatile unsigned short * _Tgt, unsigned short _Value) Line 1166	C++
 	WorldServer.exe!std::_Atomic_fetch_add_2(volatile unsigned short * _Tgt, unsigned short _Value, std::memory_order _Order) Line 1188	C++
 	WorldServer.exe!std::atomic_fetch_add_explicit(std::atomic_ushort * _Atom, unsigned short _Value, std::memory_order _Order) Line 1175	C++
 	WorldServer.exe!std::atomic_ushort::fetch_add(unsigned short _Value, std::memory_order _Order) Line 1394	C++
 	WorldServer.exe!Client::GetAndIncrementServerSequence() Line 237	C++
 	WorldServer.exe!Client::PushOutgoing(SOEProtocolData * data, bool dump_packet) Line 371	C++
 	WorldServer.exe!Client::QueuePacket(SOEProtocolData * data, bool dump_packet) Line 305	C++
 	WorldServer.exe!WorldCharacter::SendRequestChatChannel() Line 489	C++
 	WorldServer.exe!ChunkServer::CheckPlayerChangedContinents(std::shared_ptr<Client> & client, std::shared_ptr<WorldCharacter> & character) Line 1875	C++
 	WorldServer.exe!ChunkServer::HandleClientAuthConfirm(std::shared_ptr<Client> & client, PacketStruct * packet_struct) Line 1311	C++
 	WorldServer.exe!ChunkServer::ProcessPackets() Line 377	C++
 	WorldServer.exe!ChunkPacketThread(void * data) Line 121	C++
 	WorldServer.exe!ThreadRun(void * arg) Line 77	C++
 	WorldServer.exe!_callthreadstart() Line 255	C
 	WorldServer.exe!_threadstart(void * ptd) Line 239	C
 	kernel32.dll!7716337a()	Unknown
 	[Frames below may be incorrect and/or missing, no symbols loaded for kernel32.dll]	
 	ntdll.dll!77c492e2()	Unknown
 	ntdll.dll!77c492b5()	Unknown

[John Adams]

^ moved post (Xinux and Shargash's recount), because the common thing I see here is "CheckPlayerChangedContinents".

This was Black's implementation, so I recommend someone review that entire process and fix it if needed. If "checking changed continents" is not needed in HandleClientAuthConfirm, remove it.

[Xinux]

Code: Select all

 	ntdll.dll!77cb8537()	Unknown
 	[Frames below may be incorrect and/or missing, no symbols loaded for ntdll.dll]	
 	WorldServer.exe!Mutex::ReadLock() Line 99	C++
 	WorldServer.exe!WorldCharacter::IsInChatChannel(unsigned int id) Line 218	C++
>	WorldServer.exe!WorldCharacter::SendChatChannels() Line 374	C++
 	WorldServer.exe!ChunkServer::CheckPlayerChangedContinents(std::shared_ptr<Client> & client, std::shared_ptr<WorldCharacter> & character) Line 1917	C++
 	WorldServer.exe!ChunkServer::HandleClientAuthConfirm(std::shared_ptr<Client> & client, PacketStruct * packet_struct) Line 1350	C++
 	WorldServer.exe!ChunkServer::ProcessPackets() Line 377	C++
 	WorldServer.exe!ChunkPacketThread(void * data) Line 121	C++
 	WorldServer.exe!ThreadRun(void * arg) Line 77	C++
 	WorldServer.exe!_callthreadstart() Line 255	C
 	WorldServer.exe!_threadstart(void * ptd) Line 239	C
 	kernel32.dll!7716337a()	Unknown
 	ntdll.dll!77c492e2()	Unknown
 	ntdll.dll!77c492b5()	Unknown

23:39:13.034 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.034 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.035 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.036 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.037 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.038 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:39:13.039 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.040 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.040 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.041 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.042 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.043 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.044 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:39:13.045 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.046 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:39:13.047 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.048 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.049 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.049 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.050 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.051 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.052 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.053 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.054 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.055 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.056 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.057 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.058 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.059 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.060 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.061 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:39:13.062 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.063 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.063 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.064 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:39:13.064 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:39:13.065 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.066 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.066 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.067 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.067 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.073 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.074 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.075 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.085 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.088 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.096 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.097 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.098 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.099 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.100 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.101 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.102 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.103 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.104 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.105 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.105 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.106 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.107 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.108 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.109 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.110 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.111 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.112 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.113 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.114 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.115 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.116 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.117 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.118 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.119 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.120 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.120 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.121 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.122 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.123 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.124 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.125 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.125 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.126 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.127 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.128 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.129 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.130 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.130 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.131 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.132 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.133 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.134 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:39:13.135 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:39:13.135 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.137 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.138 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.141 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:39:13.142 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:39:13.143 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.144 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.145 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.146 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.147 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.148 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.149 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.150 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:334
23:39:13.151 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.153 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.154 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.154 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.155 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.156 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.157 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.158 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:217.
23:39:13.159 E Attrib Failed to get character chunk at c:\vgoemu\src\world\worldcharacter_attributes.cpp:835
23:39:13.161 E Ability WorldCharacter::CharacterAddForm: Error adding form to character map: A form for form_id '320' already exists
23:39:13.161 E Ability WorldCharacter::CharacterAddForm: Error adding form to character map: A form for form_id '366' already exists
23:39:13.162 D Ability Loaded 2 forms for character id 750.
23:39:13.164 E Char AddTitle: The character Edward already has the title 'Citizen'.
23:39:13.165 E Char AddTitle: The character Edward already has the title 'of VGOEmulator'.
23:39:13.167 D Char Loading Inventory for character_id 750
23:39:13.172 I Char Loaded 19 items for character_id 750
23:39:13.174 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Loud Criticism'.
23:39:13.175 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Enticing Whisper'.
23:39:13.175 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Read My Lips'.
23:39:13.176 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Shifting Arguments'.
23:39:13.177 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Gut Feeling'.
23:39:13.178 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Greener Pastures'.
23:39:13.179 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Aggressive Statement'.
23:39:13.180 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Itemized Comparison'.
23:39:13.180 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Flat Dismissal'.
23:39:13.181 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Lay Blame'.
23:39:13.182 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Truth Be Told'.
23:39:13.183 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Disarming Rebuttal'.
23:39:13.184 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Snippet of Wisdom'.
23:39:13.185 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Frank Discussion'.
23:39:13.185 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Exchange of Views'.
23:39:13.186 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Common Ground'.
23:39:13.187 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Moral Authority'.
23:39:13.188 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Varanthari Stare'.
23:39:13.189 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Sorcerer's Point'.
23:39:13.189 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Piece of Mind'.
23:39:13.190 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Bit of Charm'.
23:39:13.191 E Diplo AddDiplomacy: The character Edward already has the diplomacy card 'Flash of Inspiration'.
23:39:13.193 D Char ToggleIsOnline: Setting player online
23:39:13.197 D Char Successfully loaded character 'Edward Flett' (750)

[zippyzee]

I did update the code on this to hopefully prevent more of it. It's in my latest commit.

[Xinux]

I was just about to do what you just did lol o well i added a few more checks in other parts of the project.

[John Adams]

[quote="zippyzee"]I did update the code on this to hopefully prevent more of it. It's in my latest commit.[/quote]
Unfortunately, I cannot apply the latest zippy commit due to the need to extensively test questing first. I will go peel out just this fix and apply it, then.