Potential Bug/Misbehaving: GetIsOnline()

[John Adams]

I'd like to ask one of you devs to take some time to investigate this behavior; There is some serious spamming going on in WorldCharacter relating to checking GetIsOnline() in many functions that appear to be tied to players logging on (I get hundred of log lines when I turn on my new Logger for this)

Code finds:

Code: Select all

Find all "->GetIsOnline()", Subfolders, Find Results 1, Current Project: VCProjects\WorldServer.vcxproj, ""
  C:\vgoemu\src\world\Combat.cpp(96):		if (character->IsZoning() || (!character->GetCombatState() && hated_by.empty()) || character->GetIsDead() || !character->GetIsOnline())
  C:\vgoemu\src\world\DiplomacyInfoList.cpp(347):	if (this->GetIsOnline()) {		// Is this really needed?
  C:\vgoemu\src\world\DiplomacyInfoList.cpp(376):	if (this->GetIsOnline()) {
  C:\vgoemu\src\world\Mail.cpp(602):		if (recipient_character->GetIsOnline()){
  C:\vgoemu\src\world\WorldCharacter.cpp(947):	if (this->GetIsOnline()) {		// Is this really needed?
  C:\vgoemu\src\world\WorldCharacter.cpp(978):	if (this->GetIsOnline()) {		// Is this really needed?
  C:\vgoemu\src\world\WorldCharacter.cpp(1021):	if (this->GetIsOnline()) {		// Is this really needed?
  C:\vgoemu\src\world\WorldCharacter.cpp(1060):	if (this->GetIsOnline()) {		// Is this really needed?
  C:\vgoemu\src\world\WorldCharacter.cpp(1236):	if (this->GetIsOnline()) {		// Is this really needed?
  C:\vgoemu\src\world\WorldCharacter.cpp(1292):		if (this->GetIsOnline()) {
  C:\vgoemu\src\world\WorldCharacter.cpp(1305):		if (this->GetIsOnline()) {
  C:\vgoemu\src\world\WorldCharacter.cpp(1318):	if (this->GetIsOnline()) {		// Is this really needed?
  C:\vgoemu\src\world\WorldCharacter.cpp(1431):	if (this->GetIsOnline()) {		// Is this really needed?
  C:\vgoemu\src\world\WorldCharacter.cpp(1467):		if (this->GetIsOnline()) {
  C:\vgoemu\src\world\WorldCharacter.cpp(1480):		if (this->GetIsOnline()) {
  C:\vgoemu\src\world\WorldCharacter.cpp(1493):	if (this->GetIsOnline()) {		// Is this really needed?
  C:\vgoemu\src\world\WorldCharacter.cpp(1534):	if (this->GetIsOnline()) {		// Is this really needed?
  C:\vgoemu\src\world\WorldCharacter.cpp(1565):	if (this->GetIsOnline()) {		// Is this really needed?
  C:\vgoemu\src\world\WorldCharacter.cpp(3060):	if (this->GetIsOnline()) {
  C:\vgoemu\src\world\WorldCharacter.cpp(3094):	if (this->GetIsOnline()) {
  C:\vgoemu\src\world\WorldCharacter.cpp(3137):	if (this->GetIsOnline() == false) {
  C:\vgoemu\src\world\WorldCharacter.cpp(3305):	if (!this->GetIsOnline()) {
  C:\vgoemu\src\world\WorldCharacter.cpp(4634):	if (this->GetIsOnline()) {
  C:\vgoemu\src\world\WorldCharacter.cpp(4668):	if (this->GetIsOnline()) {
  C:\vgoemu\src\world\WorldCharacter.cpp(4733):	if (this->GetIsOnline()) {
  C:\vgoemu\src\world\WorldCharacter.cpp(4767):	if (this->GetIsOnline()) {
  C:\vgoemu\src\world\WorldDatabase.cpp(2330):									character->GetCurrentChunkID(), ( character->GetIsOnline() ) ? 1 : 0,\
  Matching lines: 27    Matching files: 5    Total files searched: 247

There's not a horrible amount of calls, but I want someone to explain to me what this is doing, and what's the need to check GetIsOnline() during these functions. I'm trying to understand why the } else { is getting hit so often, as it makes me think something is wrong if that flag is not set.

Someone please find the time to analyze this and let me know if failing this check is somehow a problem.