I think I just crashed the server

[shargash]

I was playing with the .item command. I added a pristine vielthread bag (1013704, iirc) and moved it to a bag slot. It opened as a bag just fine. Then I added two more. When I went to deploy them in bag slots, the bags disappeared from my inventory, but did not show up in bag slots. I tried to delete the bags. One of the deletes appeared to be successful. I camped and came back in. At that point, I appeared to have one bag in my inventory, but it was basically a phantom. I could move it from one inventory slot to another, but couldn't equip it or delete it. I then tried to add a different kind of bag, figuring the server didn't like multiple items with the same "unique" item ID. The .item command did not respond, nor did any other commands, including /camp. I tried running to a chunk line to see if chunking would do anything, however I got a CTD before I got far. When I came back in, New Telon did not appear to be up.

[Xinux]

I'm unable to remote into the box so it will have to wait till John can take a look at it sorry.

[zippyzee]

That bug has been fixed with items, as it was a pointer issue overwriting similar items. I know it has been fixed because it drove me nuts for 2 hours today. I won't be committing it to the svn for a bit (I have other testing to do first), so you'll have to ignore it for now.

That being said, I played around with it for hours and never crashed my server. Internally it is just assigning the same bag slots to several of the items so they don't show up correctly in your bags. It really has no other ramifications that I can think of. You can do the command .item delete <unique_id> for those items (they will have the same unique_id when viewed with .inventory until you back them out to the first instance of that item. In the meantime try not to push the system too far!

[John Adams]

FYI

Stack

Code: Select all

 	WorldServer.exe!WorldCharacter::GetOpenInvSlot() Line 1794	C++
 	WorldServer.exe!WorldCharacter::CharAddItem(unsigned int item_id) Line 1885	C++
 	WorldServer.exe!CommandProcess::CommandItemAdd(std::shared_ptr<Client> & client, Separator * sep, unsigned char cmd_index, bool world_client) Line 1819	C++
>	WorldServer.exe!CommandProcess::Process(std::shared_ptr<Client> & client, Separator * sep, unsigned char command_index, bool world_client) Line 244	C++
 	WorldServer.exe!ChunkServer::HandleChatSay(std::shared_ptr<Client> & client, PacketStruct * packet_struct) Line 912	C++
 	WorldServer.exe!ChunkServer::ProcessPackets() Line 337	C++
 	WorldServer.exe!ChunkPacketThread(void * data) Line 131	C++
 	WorldServer.exe!ThreadRun(void * arg) Line 77	C++
 	WorldServer.exe!_callthreadstart() Line 255	C
 	WorldServer.exe!_threadstart(void * ptd) Line 239	C
 	kernel32.dll!7574338a()	Unknown
 	[Frames below may be incorrect and/or missing, no symbols loaded for kernel32.dll]	
 	ntdll.dll!77329f72()	Unknown
 	ntdll.dll!77329f45()	Unknown

Console:
[quote]12:27:51.831 I UDP New client connected from 98.115.70.42:57891
12:27:51.831 I UDP Received session request from 98.115.70.42:57891 with connection ID 928832171
12:27:52.049 I Chunk New Session: Account ID: 273 Session ID: 'q4em637dk6dao8a8h2eceg2n50'
12:27:52.268 D Chunk control_text='HELLO REVISION=0 MINVER=3151 VER=3186'
12:27:52.439 D Chunk control_text='LOGIN'
12:27:53.406 I UDP Client from 98.115.70.42:57043 has been removed.
12:27:53.406 D Account Client Destroyed: 2
12:27:54.545 D Chunk control_text='JOIN'
12:27:54.608 D Char Loaded 8 HotButton(s) for player Shargash (477)
12:27:54.608 D Chunk In ChunkServer::PushItem2Client: Sent packet = Pristine Vielthread Bag
12:27:54.623 D Chunk In ChunkServer::PushItem2Client: Sent packet = Pristine Vielthread Bag
12:27:54.639 D Chunk In ChunkServer::PushItem2Client: Sent packet = Pristine Vielthread Bag
12:27:54.654 D Chunk In ChunkServer::PushItem2Client: Sent packet = Pristine Vielthread Bag
12:27:54.670 D Chunk In ChunkServer::PushItem2Client: Sent packet = Pristine Vielthread Bag
12:27:54.686 D Chunk In ChunkServer::PushItem2Client: Sent packet = Pristine Vielthread Bag
12:28:17.493 D Command Player 'Shargash' used command '.item:remove' (40)
12:28:22.267 E Chunk WorldCharacter:HandleClientEquip: Failed to get item unique id 7
12:28:24.170 E Chunk WorldCharacter:HandleClientEquip: Failed to get item unique id 7
12:28:26.931 E Chunk WorldCharacter:HandleClientEquip: Failed to get item unique id 7
12:28:30.597 I Chunk Deleting Item with Unique ID:7
12:28:30.597 I Chunk Removing unique id 7 from character Shargash
12:28:30.597 I Char In WorldCharacter::RemoveItem Removing item #7 from character inventory
12:28:30.597 E Char CharRemoveItem: Failed to get item at c:\vgoemu\src\world\worldcharacter.cpp:1957
12:28:30.597 E Chunk ChunkServer::HandleClientDeleteItemSingle: Failed to delete item unique id 7 from character Shar
gash
12:28:32.953 I Chunk Deleting Item with Unique ID:7
12:28:32.953 I Chunk Removing unique id 7 from character Shargash
12:28:32.953 I Char In WorldCharacter::RemoveItem Removing item #7 from character inventory
12:28:32.953 E Char CharRemoveItem: Failed to get item at c:\vgoemu\src\world\worldcharacter.cpp:1957
12:28:32.953 E Chunk ChunkServer::HandleClientDeleteItemSingle: Failed to delete item unique id 7 from character Shar
gash
12:28:35.340 E Chunk ChunkServer::HandleClientInvMove could not find object unique_id 7 in inventory
12:28:36.915 E Chunk ChunkServer::HandleClientInvMove could not find object unique_id 7 in inventory
12:28:55.963 D Char Player 'Shargash' (477) Deleted HotButton m_wb, slot 7
12:28:55.979 D Char Player 'Shargash' (477) Update HotButton m_wb, slot 7
12:28:57.804 D Command Player 'Shargash' used command '.item:add' (39)
[/quote]

[zippyzee]

The changes I made should prevent that. I'll try to get the fix up sooner rather than later.

[John Adams]

No worries, world ran for days without issue. I merely posted the stack in case it wasn't something we knew about.

Take your time. I'm MIA for a bit anyway (and no idea why Xinux couldn't remote in... update no-ip?)