Bug 209: (Faux) Offline Guild Members show Online

[BugTracker]

Bug ID       : 209 - Offline Guild Members show Online 
Bug Date     : 2015/07/01 07:55:28
Assigned To  : Faux
Priority     : High

Category     : VGClient
Sub-Category : Graphics: Other
Severity     : Minor (e.g. Cosmetic)
Reproducible : Every time

Details:
Guild display says 35 members online out of 144. However, there are only 7 of us online.

Originated From World: New Telon (1)
Chunk                : Khal (85)
Location             : -2545 -50779 1659

Entered on Jul 02, 2015 19:07 by John Adams
Faux already knows about this, we've discussed it on the forums for months. He's working on a fix.

[Faux]

Previously, characters only got their online flag set to false if they camped out normally, but since apparently everyone force quits or bypasses camp, it wasn't working. Bypassing camp as a GM now should update the flag, but I don't have force quitting handled yet. The changes haven't been committed yet, but will this weekend.

[Blackstorm]

for the brutal "quit" i have the solution, like me you can change the variables at these points : Net::CheckPendingCharacterDeletions() and ChunkServer::DisconnectChunkClient()

[John Adams]

Change what variables to what? And what is the net effect of doing so for normal disconnects?

[Faux]

[quote="Blackstorm"ChunkServer::DisconnectChunkClient()[/quote]

This is where I moved the code to update a character's guild flag to offline.

[Blackstorm]

ok, so the NET function is when the client is disconnect (quit).

this function check if the client is always connected, after a timer, if the client is really disconnected you can do the same thing. (cleanup the online/offline value)

[Blackstorm]

ok, on current NT it's not fixed yet. i am looking that.

Otherwise:
ChunkServer::DisconnectChunkClient() is for a /camp disconnection
Net::CheckPendingCharacterDeletions() is for a /quit disconnection

both need to be checked to be sure of the way which the character is disconnected. (the first one react directly after the camp timer, the second, after the client heartbeat timer timeout)

[Blackstorm]

Fixed on rev1404

[Jakkal]

Bumping this as it's now doing it again after a crash of New Telon.