Page 1 of 1
Bug 209: (Faux) Offline Guild Members show Online
Posted: Thu Jul 02, 2015 6:46 pm
by BugTracker
Bug ID : 209 - Offline Guild Members show Online
Bug Date : 2015/07/01 07:55:28
Assigned To : Faux
Priority : High
Category : VGClient
Sub-Category : Graphics: Other
Severity : Minor (e.g. Cosmetic)
Reproducible : Every time
Details:
Guild display says 35 members online out of 144. However, there are only 7 of us online.
Originated From World: New Telon (1)
Chunk : Khal (85)
Location : -2545 -50779 1659
Entered on Jul 02, 2015 19:07 by John Adams
Faux already knows about this, we've discussed it on the forums for months. He's working on a fix.
Re: Bug 209: (Faux) Offline Guild Members show Online
Posted: Thu Jul 02, 2015 7:35 pm
by Faux
Previously, characters only got their online flag set to false if they camped out normally, but since apparently everyone force quits or bypasses camp, it wasn't working. Bypassing camp as a GM now should update the flag, but I don't have force quitting handled yet. The changes haven't been committed yet, but will this weekend.
Re: Bug 209: (Faux) Offline Guild Members show Online
Posted: Sun Jul 19, 2015 12:15 pm
by Blackstorm
for the brutal "quit" i have the solution, like me you can change the variables at these points : Net::CheckPendingCharacterDeletions() and ChunkServer::DisconnectChunkClient()
Re: Bug 209: (Faux) Offline Guild Members show Online
Posted: Sun Jul 19, 2015 12:21 pm
by John Adams
Change what variables to what? And what is the net effect of doing so for normal disconnects?
Re: Bug 209: (Faux) Offline Guild Members show Online
Posted: Sun Jul 19, 2015 1:30 pm
by Faux
[quote="Blackstorm"ChunkServer::DisconnectChunkClient()[/quote]
This is where I moved the code to update a character's guild flag to offline.
Re: Bug 209: (Faux) Offline Guild Members show Online
Posted: Sun Jul 19, 2015 1:37 pm
by Blackstorm
ok, so the NET function is when the client is disconnect (quit).
this function check if the client is always connected, after a timer, if the client is really disconnected you can do the same thing. (cleanup the online/offline value)
Re: Bug 209: (Faux) Offline Guild Members show Online
Posted: Fri Jul 24, 2015 3:01 am
by Blackstorm
ok, on current NT it's not fixed yet. i am looking that.
Otherwise:
ChunkServer::DisconnectChunkClient() is for a /camp disconnection
Net::CheckPendingCharacterDeletions() is for a /quit disconnection
both need to be checked to be sure of the way which the character is disconnected. (the first one react directly after the camp timer, the second, after the client heartbeat timer timeout)
Re: Bug 209: (Faux) Offline Guild Members show Online
Posted: Fri Jul 24, 2015 3:34 am
by Blackstorm
Fixed on rev1404
Re: Bug 209: (Faux) Offline Guild Members show Online
Posted: Sat Jan 23, 2016 7:58 pm
by Jakkal
Bumping this as it's now doing it again after a crash of New Telon.