VGOEmulator.net

Bug ID       : 49 - I was in game, had the Broker ... 
Bug Date     : 2014/11/22 10:16:01
Assigned To  : Volt
Priority     : High

Category     : VGClient
Sub-Category : User Interface: (Default)
Severity     : Severe (e.g. Exploitable)
Reproducible : Some of the time

Details:
I was in game, had the Broker as my offensive target when I crashed to Char Select. When I returned, I had no targets that I was aware of, but targetted a Player next to me and hit the "H" key to Hail him. The Broker dialog opened. This bug is to handle offensive/defensive targeting better for Hail commands (I still do not think H should open dialogs at all, but merely say Hail, so-and-so) This specific issue would not happen if the character disconnected was destroyed entirely, just a chance I happened to catch it.

Originated From World: New Telon (1)
Chunk                : Khal (85)
Location             : -6475 -52572 1552

Excellent information. This reinforces my thoughts that the Client object isn't being destroyed properly (or the information the Client object holds, anyway) when a character relogs.

The info of a character's targets (defensive and offensive) are attributes on the WorldCharacter object (or rather its parent).

This bug is most likely a side effect from when it was changed to preserve the character object through a crash.

I'd rather see us going back to destroying the character object with the client at a crash / brute force forcing of the client, also because there might be more yet unthought off side-effects, and our time is better put elsewhere. (Maybe this is already in progress; viewtopic.php?f=4&t=1108 ?)

Second best is probably to clear the characters targets when it comes back online after a (short) crash. For that I need a handler (= a place in the code) where I should put the call for that.

I propose to change priority from high to low, due to the circumstances when this happens. If you tell me how to do it I can do it myself.

I can make a revisit on the cases when we need the system (server) to clear the characters target once the solution around crash and reconnect is stabilized.

If you want to recreate crash to char selects, just breakpoint your code somewhere, for about 5 seconds and then resume. Sometimes you will CTD, sometimes to Char Select.

I read your above post again. I'm more in favour of your last paragraph. I'll create a thread to keep track of my plan for this, as what I want to do is create a simple function that resets the WorldCharacter object when the BeginDisconnectFromServer routine is run.

[quote="Volt"]If you tell me how to do it I can do it myself.[/quote]
Simple, click the link in the above post, Bug Details, Priority.
It won't change the post icon, but you can edit the opening post if you want to take it that far. I think if you click Assign again, it will add a new post after the last one in the thread showing the changes.


Edit: If you are talking about the "Severity" that comes from the VGClient, you are correct. No one (not even me) can change that value. That's the submitters determination of how critical the issue is. We use Priority when determining the real urgency

Bug ID       : 49 - I was in game, had the Broker ... (Re-assigned)
Bug Date     : 2014/11/22 10:16:01
Reassigned To: Volt
Priority     : Low

Category     : VGClient
Sub-Category : User Interface: (Default)
Severity     : Severe (e.g. Exploitable)
Reproducible : Some of the time

Details:
I was in game, had the Broker as my offensive target when I crashed to Char Select. When I returned, I had no targets that I was aware of, but targetted a Player next to me and hit the "H" key to Hail him. The Broker dialog opened. This bug is to handle offensive/defensive targeting better for Hail commands (I still do not think H should open dialogs at all, but merely say Hail, so-and-so) This specific issue would not happen if the character disconnected was destroyed entirely, just a chance I happened to catch it.

Originated From World: New Telon (1)
Chunk                : Khal (85)
Location             : -6475 -52572 1552